-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix linux build #4
Conversation
build-cmd.sh
Outdated
#compiler only (g++), when introduced into CFLAGS it causes gcc (the C compiler) | ||
#to spam a load of noise.. Strip out any C++ std cruft from CFLAGS (squelches the noise) | ||
CFLAGS=$(echo "$CFLAGS" | sed 's/-std=c++[0-9][0-9]*//') | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest inserting at line 30 or thereabouts:
# remove_cxxstd
source "$(dirname "$AUTOBUILD_VARIABLES_FILE")/functions"
Then at lines 126 and 207:
CFLAGS="$(remove_cxxstd $opts)" \
That's what we've done in some other 3p build-cmd.sh
scripts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Revised commit - incorporated recommendations from Nat.
If this fixes linux compilation should a linux build be added to the CI? #7 |
Also, it looks like all the builds have failed to publish any assets. Looking into this --I believe it's due to a problem with action-autobuild and action-autobuild-release. |
Linux artifact published here: https://github.com/secondlife/3p-libpng/releases/tag/v1.16.38-d427738 Enjoy, and let me know if there are any issues. |
Thank you for publishing the artifacts, I have submitted a PR for 3p-freetype to update the stale dependency. I hope it will be valid despite this being a "pre-release" version. |
It is primarily the unit tests in build-cmd.sh that causes the build to fail for linux; these are commented out on the other platforms, so, the solution was obvious here. Also a couple of minor cleanups in build-cmd.sh for linux.