Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rust base image #21

Merged
merged 1 commit into from
Nov 30, 2023
Merged

update rust base image #21

merged 1 commit into from
Nov 30, 2023

Conversation

hydai
Copy link
Member

@hydai hydai commented Nov 30, 2023

Fixed #20
Fixed #16

@hydai hydai requested review from juntao and dm4 November 30, 2023 13:39
Copy link
Member

juntao commented Nov 30, 2023

Hello, I am a code review bot on flows.network. Here are my reviews of code commits in this PR.


Commit 22d4c134e5b2b449e2bc9b2c67e180df3f1e4b62

Key changes:

  • The base image has been updated from rust:1.69 to rust:1.71.
  • The installation of git and clang packages has been removed.
  • The installation of WasmEdge and the AOT compiler has been removed.
  • The AOT Wasm binary is now copied using the cp command instead of using the wasmedgec command.

Potential problems:

  • The removal of the git and clang packages might affect the build process if they are needed by the project.
  • The removal of the installation of WasmEdge and the AOT compiler might affect the functionality of the application if they are required.
  • It's unclear why the installation of WasmEdge and the AOT compiler has been removed. This change should be explained in the pull request or accompanied by other relevant changes in the code.
  • The build process has been simplified, but it's important to ensure that the simplified process still produces the expected results. It should be verified that the AOT Wasm binary is built correctly using the new approach.

@hydai hydai merged commit 5776081 into main Nov 30, 2023
1 check passed
@hydai hydai deleted the hydai/bump_rust_image branch November 30, 2023 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants