Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly set registerVal max count to 123 to override global limit #4633

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

satveerbrar
Copy link
Contributor

Added max_count=123 to the FieldListField for the registerVal field to override the global conf.max_list_count =100

fixes #4573

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.59%. Comparing base (c424205) to head (7817309).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4633      +/-   ##
==========================================
- Coverage   81.61%   81.59%   -0.03%     
==========================================
  Files         359      341      -18     
  Lines       86052    85781     -271     
==========================================
- Hits        70234    69991     -243     
+ Misses      15818    15790      -28     
Files with missing lines Coverage Δ
scapy/contrib/modbus.py 90.98% <ø> (ø)

... and 273 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modbus packet not being parsed correctly in 2.6.0
1 participant