-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fixes for PHP 8.2 #522
base: master
Are you sure you want to change the base?
Conversation
Code cleanup
… other dependencies.
Improved Polish translation
Some new user agents and a revised one (all for Android apps) **User Agent was changed by the app** UserAgent: `EBookDroid` Android app: Ebookdroid https://play.google.com/store/apps/details?id=org.ebookdroid **New User Agents** UserAgent: `BookReader` Android app: Gorser Ebookreader - https://play.google.com/store/apps/details?id=com.gorser.ebookreader.epub UserAgent: `CoolReader` Android app: Cool Reader https://play.google.com/store/apps/details?id=org.coolreader UserAgent: `PageTurner` Android app: PageTurner eBook Reader - https://play.google.com/store/apps/details?id=net.nightwhistler.pageturner.ads UserAgent: `books\.ebook\.pdf\.reader` Android app: EBook Reader & PDF Reader - https://play.google.com/store/apps/details?id=books.ebook.pdf.reader Note: it also works with `books.ebook.pdf.reader` UserAgent: `com\.hiwapps\.ebookreader` Android app: Ebook reader (from Hiwapps)- https://play.google.com/store/apps/details?id=com.hiwapps.ebookreader Note: app does not support epub format UserAgent: `OpenBook` Android app: https://play.google.com/store/apps/details?id=app.angeldroid.openbook
Changing cog icon (in the header) to a magnifying glass / search Why? Magnifying glass its usually considered the search button when the Cog is considered a "configuration tool". With actual COPS theme people always ask me "where is the search button"? Note: To play with Search icon size (and make it smaller) see my initial commits to this PR
…n02 for the PR. fixes seblucas#307 and seblucas#308
Android user agent for OPDS reader update
…nd some small other formatting fixes.
the ouput gets a lot bigger but if I do somthing about it this file will become a mess.
…install COPS Small other stuff, nothing big
…n the top). The top margin is already on the cover so there is no need to add it also in the book title.
That should help in keeping the lock file consistent.
Also some small other changes
The 1.2.3 package linked to above is throwing errors for me:
|
Good to know, thanks @dunxd - I may have missed cleaning up the development autoload files before making the .zip package, sorry about that. If you happen to have composer 2 installed on your system, you can simply install/update the packages again:
That will:
You'll find an updated cops-1.2.3b.zip package on the release page above... |
@mikespub This project is no longer maintained by DEV. |
Hi @horus68 I certainly appreciate your enthusiasm and willingness to help out, as I've seen in these issues and PRs as well :-) But I'm afraid I won't be able to maintain this project on a regular basis though. This was just a temporary "itch" to scratch for me: So far I've cleaned up and fixed all the PHP 8.2 issues that I found, updated dependencies where I could without major rewrite, and merged the most "interesting" pull requests or forks I discovered into the main code base here. If there's another big one I missed please let me know... Soon some other "developer" will come around with his/her own wish list, and they'll be able to pick off from this pull request, or fork directly from https://github.com/mikespub-org/seblucas-cops to continue improving it. And in the meantime "regular" users will be able to use the packages I prepared as starting point, and perhaps a kind "distributor" will prepare and maintain some modern docker images based on what I've started... And so the project lives on :-) |
Just got back from a holiday, and have been using the 1.3.2 release and not getting so many errors. Thanks for your work on this @mikespub . |
Further updates are available directly from https://github.com/mikespub-org/seblucas-cops on the main branch. |
See https://github.com/mikespub-org/seblucas-cops/releases to download unofficial "1.2.3" or "1.3.2" packages, or
clone/download source code from master branch directly from https://github.com/mikespub-org/seblucas-cops