Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use absolute path in place of partial one and calibre internal directory #505

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andresmoschini
Copy link

Using the calibre internal directory concatenated to the relative path is not enough when there is more than a library.

Before:

image

After:

image

…irectory

Using the _calibre internal directory_ concatenated to the _relative path_ is not enough when there is more than a library.
@andresmoschini
Copy link
Author

😴💤💤

@andresmoschini
Copy link
Author

Any news on this?

@horus68
Copy link
Contributor

horus68 commented Jan 31, 2022

Can you place here your related config path for the libraries so it could be tested?

@andresmoschini
Copy link
Author

Can you place here your related config path for the libraries so it could be tested?

This is the section in de file config_local.php:

<?php
    if (!isset($config))
        $config = array();

    /*
     * The directory containing calibre's metadata.db file, with sub-directories
     * containing all the formats.
     * BEWARE : it has to end with a /
     */

    // $config['calibre_directory'] = '/books/';
    $config['calibre_directory'] = array(
        "Combo 625" => "/books/Combo625/",
        "Biblio75k" => "/books/Biblio75k/",
        "Papyrefb2_v6" => "/books/Papyrefb2_v6/",
        "LibrosImportados" => "/books/LibrosImportados/");

    $config['calibre_internal_directory'] = '/books/';

    /*
     * Catalog's title
    // . . .

@andresmoschini
Copy link
Author

@horus68 was my configuration useful for you?

@andresmoschini
Copy link
Author

Hi @horus68 did you have a chance to review it?

@marioscube
Copy link

I have incorporated your code in the COPS code.

It still works.

I had no problems with the original COPS code (nor with yours).

I am using apache2, php7 and multiple calibre_directories.

And $config['calibre_internal_directory'] = '';

Do you use nginx?

However the creator of COPS used nginx............... (??)

@andresmoschini
Copy link
Author

Thanks for taking the time and for your response!

Do you use nginx?

I am using it with docker in a raspberry pi, and yes, it seems that I am using nginx: https://github.com/andresmoschini/docker-cops/blob/master/Dockerfile.armhf#L1

@marioscube
Copy link

If it works for you, GREAT!
It also works with my apache2 php7 setup, but it does not seem necessary.

I will see if I can test it with a docker container (tomorrow?).

@marioscube
Copy link

Tested with a COPS-docker container on debian 10 (not on a Pi):

I cannot confirm the 404!

For me it works.

But again, if it works for you.... :-)

@andresmoschini
Copy link
Author

Ok, thanks, so, I will continue with my fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants