Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add enemy constraints for event drop systems #664

Merged

Conversation

pacampbell
Copy link
Collaborator

@pacampbell pacampbell commented Dec 19, 2024

  • Added new EventItemConstraint values
    • LessThan
    • LessThanOrEqual
    • GreaterThan
    • GreaterThanOrEqual
    • InRange
  • Added the ability to define constraints based on enemy level
    • If the constraint is 'InRange' the fields 'min_lv' and 'max_lv' are required.
      • "requirements": {"enemy_level" : {"constraint": "InRange", "min_lv": x, "max_lv": y}}
    • If the constraint is any of the other types the field 'lv' is required.
      • "requirements": {"enemy_level" : {"constraint": "LessThan|LessThanOrEqual|GreaterThan|GreaterThanOrEqual", "lv": x}}
  • Added the ability to define constraints based on if the enemy is a boss or not.
    • "requirements": {"enemy_class": "None|IsBoss|IsNotBoss"}

Checklist:

  • The project compiles
  • The PR targets develop branch

- Added new EventItemConstraint values
    - LessThan
    - LessThanOrEqual
    - GreaterThan
    - GreaterThanOrEqual
    - InRange
- Added the ability to define constraints based on enemy level
    - If the constraint is 'InRange' the fields 'min_lv' and 'max_lv'
      are required.
      - "requirements": {"enemy_level" : {"constraint": "InRange", "min_lv": x, "max_lv": y}}
    - If the constraint is any of the other types the field 'lv' is
      required.
      - "requirements": {"enemy_level" : {"constraint": "LessThan|LessThanOrEqual|GreaterThan|GreaterThanOrEqual", "lv": x}}
- Added the ability to define constraints based on if the enemy is a
  boss or not.
    - "requirements": {"enemy_class": "None|IsBoss|IsNotBoss"}
@pacampbell pacampbell merged commit 4d5080a into sebastian-heinz:develop Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants