Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Small fixes 12/11 #663

Merged
merged 4 commits into from
Dec 20, 2024

Conversation

RyanYappert
Copy link
Collaborator

Small fixes.

  • Don't complain about missing questScheduleIds for known progress requests associated with the world manage quests from pcaps. These are IDs 25077, 43645, 43646, 47734, 47736, 47737, 47738, 47739, 49692, 77644, 151381, 208640, 233576, 259411, 259412, 287378, 315624.
  • Don't send a client's own lobby context back to them. Doing so seems to be the cause of some unusual bugs where a character's appearance/job/etc. are "stuck" in the lobby sometimes, despite changing normally elsewhere.
    • Monitoring this to see if it causes further issues.
  • Re-implement the live service moon behavior, hopefully, based on captured data and formulas from the android app (thanks @Sehkah!).
    • This seems to be 14 real life days per Lestanian moon cycle, which consists of 30 phases. You can check the current phase with Server.WeatherManager.GetMoonPhase().

Checklist:

  • The project compiles
  • The PR targets develop branch

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we should do this instead of filtering out the data from the pcaps

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't filter out the data from the pcaps; these quests control world state and things get angry when they're not present. The problem is that they also want to progress on login, and in my tinkering with the pcaps, I couldn't get them to not progress and still properly do their world state things.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should maybe be a TODO comment to remove the IDs from this list when they get properly handled i suppose

@RyanYappert RyanYappert merged commit b7b2401 into sebastian-heinz:develop Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants