Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Crafting Calculation Improvements #661

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Feat: Crafting Calculation Improvements #661

wants to merge 1 commit into from

Conversation

RyanYappert
Copy link
Collaborator

  • Fix cost and speed calculations for crafting.
    • These should now be accurate to the client predictions to within a few gold and/or seconds.
    • Crafting timers are still not implemented.
  • Enable legend pawns where applicable (Crafting, Quality Improvement, and Enhancing)
  • Tweaks to craft analysis to interpret the thing being analyzed better.
  • Adjust pawn crafting assets and crafting tests.
    • The MockServer architecture breaks when tested functions require assets to be loaded, and I don't feel like fixing the crafting tests when this is the second time they've given me trouble.

Checklist:

  • The project compiles
  • The PR targets develop branch

@RyanYappert
Fix cost and speed calculations for crafting. Enable legend pawns whe…
dafb343 
…re applicable. Tweaks to craft analysis to interpret the thing being analyzed better. Adjust pawn crafting assets and crafting tests.
alborrajo
alborrajo approved these changes Dec 22, 2024
View reviewed changes
Copy link
Collaborator

@alborrajo alborrajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Christ

pacampbell
pacampbell reviewed Dec 22, 2024
View reviewed changes
Arrowgene.Ddon.Shared/AssetRepository.cs
@@ -42,7 +42,9 @@ public class AssetRepository
public const string JobValueShopKey = "JobValueShop.csv";
public const string StampBonusKey = "StampBonus.csv";
public const string SpecialShopKey = "SpecialShops.json";
public const string PawnCostReductionKey = "PawnCostReduction.json";
public const string PawnCostReductionKey = "PawnCostReduction.json";
public const string PawnCraftSkillCostRateKey = "PawnCraftSkillCostRate.csv";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand why we keep moving things from json back to CSV. CSV is a terrible format.

Arrowgene.Ddon.GameServer/Characters/CraftManager.cs
/// <summary>
/// TODO: Extract to asset
/// </summary>
public static readonly List<CDataRegisteredLegendPawnInfo> CraftMasterLegendPawnInfoList = new List<CDataRegisteredLegendPawnInfo>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not make a json for this now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacampbell pacampbell pacampbell left review comments

@alborrajo alborrajo alborrajo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RyanYappert @pacampbell @alborrajo