Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing drop tables for Infected Behemoth 0x015712 #650

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

13masj
Copy link
Contributor

@13masj 13masj commented Dec 5, 2024

Add missing drop tables for Infected Behemoth 0x015712

Checklist:

  • The project compiles
  • The PR targets develop branch

@pacampbell
Copy link
Collaborator

pacampbell commented Dec 6, 2024

@13masj
I tried to merge this change but looks like you also made enemy spawn changes? If you did you might need to make them again since there is a merge conflict on that file. If you did not, can you drop the file from this PR?

@13masj
Copy link
Contributor Author

13masj commented Dec 6, 2024

@13masj I tried to merge this change but looks like you also made enemy spawn changes? If you did you might need to make them again since there is a merge conflict on that file. If you did not, can you drop the file from this PR?

Yeah the exact changes I made were adding Infected Behemoth (ID 210, 211) to the middle of EnemySpawn and QuestEnemyDrops, incrementing the following IDs for EnemySpawn and then updating any ID thats present in QuestEnemyDrops to match the new IDs in EnemySpawn.

But I see that EnemySpawn.json got updated very recently. Let me update the file.

@13masj
Copy link
Contributor Author

13masj commented Dec 6, 2024

@13masj I tried to merge this change but looks like you also made enemy spawn changes? If you did you might need to make them again since there is a merge conflict on that file. If you did not, can you drop the file from this PR?

@pacampbell
EnemySpawn_fix.json
Can you try with attached file?

@pacampbell pacampbell merged commit de64b2b into sebastian-heinz:develop Dec 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants