Feature/gp shop #644
Feature/gp shop #644
Conversation
The online shop still crashes currently.
Added json asset to populate shop contents.
|
Any reason this hasn't been merged? 🤔 |
No one has reviewed it. |
There was a problem hiding this comment.
I got plenty of comments regarding strings default value. By default they get a null value, which is probably never going to be a problem in this PR since the strings are always set to a different value, but its not uncommon to leave fields without setting during testing and having the server fail to serialize a null string, which is why its better to always initialize these values.
There was a problem hiding this comment.
same comment as in the other PR, it's better to have these in alphabetical order, as theyre already grouped by the group name prefix
There was a problem hiding this comment.
Same as in the banner PR, I don't think we should include copyrighted images in the repo
| public ushort MaxSlotNum { get; set; } | ||
|
|
||
| public CDataGameItemStorageInfo() | ||
| { |
There was a problem hiding this comment.
GameItemStorage should be instanced in the constructor
| public List<CDataGachaDrawGroupInfo> DrawGroups { get; set; } | ||
|
|
||
| public CDataGachaInfo() | ||
| { |
There was a problem hiding this comment.
The strings should be instanced in the constructor
| public class CDataGPShopDisplayType | ||
| { | ||
| public uint ID { get; set; } | ||
| public string Name { get; set; } |
There was a problem hiding this comment.
This string should be instanced in the constructor
| ID = 1, | ||
| CourseID = 1, | ||
| Name = "Adventure Passport (active)", | ||
| ImageAddr = "http://localhost:52099/shop/img/payment/icon_course1.png", |
There was a problem hiding this comment.
ditto regarding localhost
| WeightDispTitle = "Percentage Provided", | ||
| WeightDispText = "Class S 100.0%\r\n*Probability of provision is rounded to one decimal place.", | ||
| ListAddr = "http://localhost:52099/shop/img/payment/icon_lot72.jpg", | ||
| ImageAddr = "http://localhost:52099/shop/img/payment/image_lot67_01_campaign2.jpg", |
| WeightDispType = 1, | ||
| FreeSpaceText = "", | ||
| ListAddr = "http://localhost:52099/sp_ingame/campaign/bnr/lotto/lot_icon_170316_03.jpg", | ||
| ImageAddr = "http://localhost:52099/sp_ingame/campaign/bnr/lotto/lot_icon_170316_03.jpg", |
| if (Server.WalletManager.RemoveFromWalletNtc(client, client.Character, walletType, request.Price)) | ||
| { | ||
| // Failed to deduct the cost | ||
| return res; |
There was a problem hiding this comment.
Shouldnt this set an error code?
Thanks for the review. This was not actually my PR but I added the JSON config to it. Anyways, will go through and fix them. |
Features:
Technical details:
Notes on testing:
Open points:
Authored-by: @Sehkah
Checklist:
developbranch