Fix cost and speed calculations for crafting. Enable legend pawns whe…

…re applicable. Tweaks to craft analysis to interpret the thing being analyzed better. Adjust pawn crafting assets and crafting tests.
sebastian-heinz · Dec 18, 2024 · dafb343 · dafb343
1 parent 86fe018
commit dafb343
Show file tree

Hide file tree

Showing 25 changed files with 960 additions and 1,844 deletions.
diff --git a/Arrowgene.Ddon.GameServer/Characters/CraftManager.cs b/Arrowgene.Ddon.GameServer/Characters/CraftManager.cs
diff --git a/Arrowgene.Ddon.GameServer/Handler/CraftGetCraftSettingHandler.cs b/Arrowgene.Ddon.GameServer/Handler/CraftGetCraftSettingHandler.cs
@@ -1,4 +1,5 @@
 using System.Collections.Generic;
+using Arrowgene.Ddon.GameServer.Characters;
 using Arrowgene.Ddon.Server;
 using Arrowgene.Ddon.Shared.Entity.PacketStructure;
 using Arrowgene.Ddon.Shared.Entity.Structure;
@@ -27,199 +28,6 @@ public class CraftGetCraftSettingHandler : GameStructurePacketHandler<C2SCraftGe
             }
         };
 
-        /// <summary>
-        /// TODO: Extract to asset
-        /// </summary>
-        private static readonly List<CDataRegisteredLegendPawnInfo> CraftMasterLegendPawnInfoList = new List<CDataRegisteredLegendPawnInfo>
-        {
-            new CDataRegisteredLegendPawnInfo
-            {
-                PawnId = 308,
-                PointType = WalletType.GoldenGemstones,
-                RentalCost = 1,
-                Unk3 = 10000004,
-                Name = "Many",
-                CraftRank = 100,
-                PawnCraftSkillList = new List<CDataPawnCraftSkill>
-                {
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.ProductionSpeed,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.EquipmentEnhancement,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.EquipmentQuality,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.ConsumableQuantity,
-                        Level = 99
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CostPerformance,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.ConsumableProductionIsAlwaysGreatSuccess,
-                        Level = 1
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CreatingHighQualityEquipmentIsAlwaysGreatSuccess,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CostPerformanceEffectUpFactor1,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CostPerformanceEffectUpFactor2,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.UnknownEffect10,
-                        Level = 0
-                    }
-                }
-            },
-            new CDataRegisteredLegendPawnInfo
-            {
-                PawnId = 309,
-                PointType = WalletType.GoldenGemstones,
-                RentalCost = 1,
-                Unk3 = 10000006,
-                Name = "Qualio",
-                CraftRank = 100,
-                PawnCraftSkillList = new List<CDataPawnCraftSkill>
-                {
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.ProductionSpeed,
-                        Level = 99
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.EquipmentEnhancement,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.EquipmentQuality,
-                        Level = 99
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.ConsumableQuantity,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CostPerformance,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.ConsumableProductionIsAlwaysGreatSuccess,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CreatingHighQualityEquipmentIsAlwaysGreatSuccess,
-                        Level = 1
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CostPerformanceEffectUpFactor1,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CostPerformanceEffectUpFactor2,
-                        Level = 1
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.UnknownEffect10,
-                        Level = 0
-                    }
-                }
-            },
-            new CDataRegisteredLegendPawnInfo
-            {
-                PawnId = 310,
-                PointType = WalletType.GoldenGemstones,
-                RentalCost = 1,
-                Unk3 = 10000002,
-                Name = "Arms",
-                CraftRank = 100,
-                PawnCraftSkillList = new List<CDataPawnCraftSkill>
-                {
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.ProductionSpeed,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.EquipmentEnhancement,
-                        Level = 99
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.EquipmentQuality,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.ConsumableQuantity,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CostPerformance,
-                        Level = 99
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.ConsumableProductionIsAlwaysGreatSuccess,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CreatingHighQualityEquipmentIsAlwaysGreatSuccess,
-                        Level = 0
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CostPerformanceEffectUpFactor1,
-                        Level = 1
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.CostPerformanceEffectUpFactor2,
-                        Level = 1
-                    },
-                    new CDataPawnCraftSkill
-                    {
-                        Type = CraftSkillType.UnknownEffect10,
-                        Level = 0
-                    }
-                }
-            }
-        };
-
         /// <summary>
         /// TODO: Extract to asset
         /// </summary>
@@ -382,7 +190,7 @@ public override void Handle(GameClient client, StructurePacket<C2SCraftGetCraftS
                 ReasonableCraftLv = 5,
                 CraftItemLv = 15,
                 CreateCountMax = Server.Setting.GameLogicSetting.CraftConsumableProductionTimesMax,
-                CraftMasterLegendPawnInfoList = CraftMasterLegendPawnInfoList,
+                CraftMasterLegendPawnInfoList = CraftManager.CraftMasterLegendPawnInfoList,
                 Unk1 = 49,
                 Unk2 = 30,
                 RefiningMaterialInfoList = RefiningMaterialInfoList