Svelte 5 Migration 2 #671
Merged
Svelte 5 Migration 2 #671
+1,057
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The current code implements the whole backend for the new theming approach with all database migrations, structs, API endpoints, caching, pre-compression, and so on. The new (default rauthy) theme has been implemented into the PUT and DELETE endpoints do exist as well already and are working. However, a UI component to modify the theme has not been implemented yet and will be built in a future PR, when the clients config view in the Admin UI is being migrated to Svelte5 as well. Doing it now would mean to do the work twice, which does not make much sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#642
This PR will take care of the way theming will be done in the future.
The old / current way of handling it is pretty inefficient and does not allow to easily use light / dark theming in combination with client branding. It also does not compress dynamically created HTML with SSR inserted values.