Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding compare_player_stats function player.py #2

Closed
wants to merge 2 commits into from
Closed

adding compare_player_stats function player.py #2

wants to merge 2 commits into from

Conversation

zmusyimiumd
Copy link

compare stats of two players.

seanoconnor23

This comment was marked as resolved.

Sign in to view

@seanyboi seanyboi requested a review from seanoconnor23 January 7, 2025 21:48
@seanyboi
Copy link
Owner

seanyboi commented Jan 7, 2025

Thanks for this submission, I will close this PR as it's not in line with how nbdev works. You can check out nbdev here and raise another PR if you like 😄 . Also, this can be achieved by running fetch_player_stats twice.

@seanyboi seanyboi closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanoconnor23 seanoconnor23 Awaiting requested review from seanoconnor23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zmusyimiumd @seanyboi @seanoconnor23