Makes parse function public
#150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seantomburke
approved these changes
Oct 24, 2024
| @@ -173,7 +173,7 @@ export default class Sitemapper { | |||
| /** | |||
| * Requests the URL and uses parseStringPromise to parse through and find the data | |||
| * | |||
| * @private | |||
| * @public | |||
There was a problem hiding this comment.
Does changing this comment change any functionality? Or is it more of a formal way of defining it public. I believe in JS the comment doesn't actually prevent anything from being accessed.
I don't see any issues with defining it as public.
seantomburke
requested changes
Oct 24, 2024
| * | ||
| * @param url URL to the sitemap.xml file | ||
| */ | ||
| parse(url?: string): Promise<ParseData>; |
There was a problem hiding this comment.
Looks like ParseData is throwing some errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #149