Filepath and raw XML Text files are now supported by the fetch method #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to fetch reads file path and raw xmlns
|
This pull request introduces 1 alert when merging 4d16e3d into 3c9fde1 - view on LGTM.com new alerts:
|
|
This pull request introduces 1 alert when merging 84c37bf into 3c9fde1 - view on LGTM.com new alerts:
|
|
Hello. Might can you merge this pr? |
myagizmaktav
commented
Nov 30, 2022
seantomburke
reviewed
Feb 1, 2024
| @@ -11,10 +12,10 @@ | |||
| "crawlers", | |||
| "webcrawler" | |||
| ], | |||
| "homepage": "http://github.com/seantomburke/sitemapper", | |||
There was a problem hiding this comment.
This PR changes the main URLs of the underlying package, so I wouldn't be able to merge this in. The NPM package needs to reference this repository and not the fork.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fetch method now working on Filepath and raw XML file