Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove lodash dependency #10

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove lodash dependency #10

wants to merge 1 commit into from

Conversation

JonasSchatz
Copy link

Pretty much what the title says :)
Removed the lodash dependency (padStart is available in plain JS by now), increased the version to 1.1.1 and wrote an additional test to confirm that the returned tokens have the expected length.

@sybohy sybohy requested a review from seveibar April 16, 2023 04:18
seveibar
seveibar approved these changes Apr 16, 2023
View reviewed changes
Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Will merge and publish soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcapretz vcapretz vcapretz approved these changes

@seveibar seveibar seveibar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JonasSchatz @seveibar @vcapretz