Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for TaskPlan and TaskAction objects #139

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Add unit tests for TaskPlan and TaskAction objects #139

merged 4 commits into from
Sep 5, 2023

Conversation

sea-bass
Copy link
Owner

@sea-bass sea-bass commented Sep 4, 2023

This PR adds some basic unit tests for the task and motion planning object representations. These classes are simple, so not much to be done here.

Closes #96

henrygerardmoore
henrygerardmoore approved these changes Sep 4, 2023
View reviewed changes
Copy link
Collaborator

@henrygerardmoore henrygerardmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one small thing I think would help, but generally LGTM and I tested it locally as well; feel free to add the comments if you want but I don't think it's critical

test/planning/test_task_objects.py Show resolved Hide resolved
@sea-bass sea-bass merged commit 95c3da4 into main Sep 5, 2023
5 checks passed
@sea-bass sea-bass deleted the test-task-objects branch September 5, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrygerardmoore henrygerardmoore henrygerardmoore approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add unit tests for TaskAction and TaskPlan objects
2 participants
@sea-bass @henrygerardmoore