SCHED0021: decrease chances of a race condition #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decrease the chance that the monitor thread is preempted just when it has released the preemption threads, but before it has yielded itself. (If that happens, the preemption threads get two time slices.) See also #42 Signed-off-by: Gerwin Klein <[email protected]>
|
After this is merged, I might try enabling this test for simulation again in a separate PR to see if it got any better. Although I don't really think it was this specific race condition that was the reason for failure there. |
Indanz
approved these changes
Oct 27, 2023
|
This should be enough to make it robust. If time_now() can't run within one time slice, there's something horribly wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decrease the chance that the monitor thread is preempted just when it has released the preemption threads, but before it has yielded itself. (If that happens, the preemption threads get two time slices.)
See also #42 -- the implementation here is basically @axel-h's suggestion from that issue.
We believe we might have seen an instance of this in one test run (of many) for PR seL4/seL4#968