Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce reliance on unstable rustc features #61

Merged
merged 48 commits into from
Jan 8, 2024
Merged

Reduce reliance on unstable rustc features #61

merged 48 commits into from
Jan 8, 2024

Conversation

nspin
Copy link
Member

@nspin nspin commented Jan 8, 2024

This project includes code which covers functionality (e.g. language runtime support) that is usually limited to in-tree libraries like libstd, so it will depend on some unstable features for the foreseeable future. However, this project has many unnecessary dependencies on unstable features. This PR removes most of those unnecessary dependencies.

As a result, it will now be easier to document and keep track of which unstable features this project depends on. I would like to reach a point where using a stable compiler with RUSTC_BOOTSTRAP feels reasonable.

We can use Rust-for-Linux/linux#2 as input to our decisions about which unstable features we are okay depending on.

nspin added 30 commits January 8, 2024 11:19
@nspin
Fix dependency features for sel4-capdl-initializer-embed-spec
866557a 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(extract_if)]
0768b33 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(is_sorted)] and #![feature(iter_intersperse)]
9aa5bf5 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(maybe_uninit_slice)]
40f5488 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(int_roundings)]
8857fec 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(let_chains)]
26215ba 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(result_flattening)]
5c6a581 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(async_fn_in_trait)]
ddf5233 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(try_blocks)]
fa225d1 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(lazy_cell)]
b68bb82 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(error_in_core)]
782a579 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(exit_status_error)]
f115b25 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(cell_update)]
994b35a 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Add hacking/unstable-feature-monitoring
52d8e8a 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(const_trait_impl)] and #![feature(derive_con…
f2d81e9 
…st)]

Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(pattern)]
7dd73b5 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(const_slice_ptr_len)]
4f0557b 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(array_try_from_fn)]
1619fde 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(c_size_t)]
fc2b50e 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove one use of #![feature(const_slice_from_raw_parts_mut)]
67e3f8e 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(const_ptr_is_null)]
d49d27b 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(const_pointer_is_aligned)]
3b31806 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(const_mut_refs)]
956711a 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(concat_idents)]
e3aadad 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(const_option)]
7c2b2e3 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(slice_as_chunks)]
3906314 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused instances of #![feature(slice_ptr_len)]
4f14337 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(atomic_from_mut)]
cc9e335 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(ptr_metadata)]
e1268b5 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused instances of #![feature(slice_ptr_get)]
4594443 
Signed-off-by: Nick Spinale <[email protected]>
nspin added 18 commits January 8, 2024 11:19
@nspin
Remove #![feature(const_slice_from_raw_parts_mut)]
8d0acb1 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
crates/sel4-dlmalloc: Refactor
d1e5e63 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(variant_count)]
535652e 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(sync_unsafe_cell)]
4f57e31 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(exclusive_wrapper)]
62a27d2 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(stdsimd)]
ee74800 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused #![feature(alloc_error_handler)]
9621742 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(array_methods)]
0820ac7 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused instances of #![feature(strict_provenance)]
00b0edf 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(strict_provenance)] from crates/sel4
e99f79a 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Add #![feature(strict_provenance)] to wishlist
c8ff0af 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(strict_provenance)]
3b590b4 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove #![feature(exposed_provenance)]
d3378b1 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Add #![feature(exposed_provenance)] to wishlist
2ca6dd9 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Restore #![feature(stdsimd)] for kernel loader on riscv
590d20c 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Add list of extra used unstable features
e77cb5d 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Remove unused instances of unstable feature attributes
bb07ce1 
Signed-off-by: Nick Spinale <[email protected]>
@nspin
Address clippy lints
20c78aa 
Signed-off-by: Nick Spinale <[email protected]>
@nspin nspin merged commit 124740a into seL4:main Jan 8, 2024
15 checks passed
@nspin nspin deleted the pr/reduce-reliance-on-unstable-features branch January 8, 2024 11:44
@nspin nspin mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nspin