Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release mode warnings and compile errors #121

Closed
wants to merge 1 commit into from
Closed

Fix release mode warnings and compile errors #121

wants to merge 1 commit into from

Conversation

Ivan-Velickovic
Copy link
Contributor

Regarding print macros not being available in release mode, I went with a similar approach as crates/sel4-microkit/src/printing.rs.

@Ivan-Velickovic Ivan-Velickovic requested a review from nspin as a code owner April 3, 2024 04:03
@Ivan-Velickovic
Copy link
Contributor Author

Not sure if this is the right approach, or whether every kind of debug_print kind of macro should have two definitions, where one is a no-op for release mode?

@nspin
Copy link
Member

nspin commented Apr 20, 2024

Thanks for finding these issues!

I've implemented some slightly different fixes for the issues addressed in this PR in #123.

I've also (finally) added some build tests to CI for release-style configurations.

I suggest closing this PR in favor of #123

@Ivan-Velickovic
Copy link
Contributor Author

Cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nspin nspin Awaiting requested review from nspin nspin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ivan-Velickovic @nspin