monitor: Increase BOOTSTRAP_INVOCATION_DATA_SIZE #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
reviewed
Oct 25, 2023
monitor/src/main.c
Outdated
| @@ -79,7 +79,7 @@ | |||
| * | |||
| * FIXME: This can be smaller once compression is enabled. | |||
| */ | |||
| #define BOOTSTRAP_INVOCATION_DATA_SIZE 110 | |||
| #define BOOTSTRAP_INVOCATION_DATA_SIZE 256 | |||
There was a problem hiding this comment.
I think the comment could also get a few more words then, where the magic value roughly comes from.
There was a problem hiding this comment.
If this part of the monitor was sticking around it would be part of #49 but it's going to be removed in the transition to capDL so I think we'll leave the comment as it is for now.
Ivan-Velickovic
force-pushed
the
pr/increase-bootstrap-invocation-data-size
branch
2 times, most recently
from
6939aaa to
6c6cf3c
Compare
To enable protection domains with larger memory footprints. Signed-off-by: Ivan Velickovic <[email protected]> Co-authored-by: Nick Spinale <[email protected]>
Ivan-Velickovic
force-pushed
the
pr/increase-bootstrap-invocation-data-size
branch
from
6c6cf3c to
24c4129
Compare
|
Lowered to 150 as internally at TS we've been able to build fairly large systems without increasing it above 150. Not that it matters much as this part of the monitor will be removed soon once the capDL initialiser is used. I just didn't want to increase the number by too much since I'd like to do a comparison of memory usage before and after the capDL changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To enable protection domains with larger memory footprints.
https://github.com/seL4/rust-microkit-http-server-demo, for example, requires at least 122
seL4_Words.