-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added maaxboard support with hello example #38
Conversation
build_sdk.py
Outdated
gcc_cpu="cortex-a53", | ||
loader_link_address=0x40480000, | ||
kernel_options = { | ||
"KernelPlatform": "imx8mq-evk", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be maaxboard
? I assume that you've put it as imx8mq-evk
as the version of seL4 that seL4CP uses doesn't have maaxboard
. The solution is to update the the seL4 version used by seL4CP then.
However, if the maaxboard
works with "KernelPlatform": "imx8mq-evk"
, why does it even exist as a separate platform in seL4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically there is the Core, the SoC and the Board (and then also the board variant ....) that you can target. If board use the same SoC, the binaries might work on the other boards also more or less But it's good practice to really select the most specific target at the moment. As far as I know, having generic images that are configured at runtime is not a goal the moment for the kernel. Not sure how the micokit plans to handle this, though.
A couple requests:
Sorry for the confusion regarding the seL4 branch right now. I'll update the |
41bf334
to
73cfde4
Compare
Hi, as per, seL4/seL4#1164 is this pull request effectively blocked until sel4 (kernel) "microkit" branch is updated to have maxxboard support, as seen on the sel4 (kernel) master branch? (Is there a link or pull-request for that dependency change?) |
Signed-off-by: Josh Felmeden <[email protected]> Signed-off-by: Ivan Velickovic <[email protected]>
That's correct. This has been done in #93. There were a couple things that needed changing, some minor style fixes but mainly the documentation in the manual for how to boot the image and also that the Were the changes tested? Just because I couldn't get the hello world to work without making the change: - #define TRANSMIT 0x49
+ #define TRANSMIT 0x40 Thanks for your patience. |
Hi, I'm pretty sure Josh tested this, but I'm not sure when, and in what configuration. I have tried building from scratch with the merged code, using the head of main branch of microkit repo, and the documented commit (7008430d4432c71a74b2a1da0afae58f7a8658df) of microkit branch of sel4 repo, and it worked for me! I got "hello, world" over the serial TTY. Note I used "debug" for MICROKIT_CONFIG -- I think the printing "hello" bit might depend on the kernel provided serial driver, which is only present in debug? Note I can't find the "TRANSMIT 0x49" line anywhere? Do you know where that came from? The pull request, and our separate sel4-cap branch, all seem to have "TRANSMIT 0x40". Since the merged "0x40" seems to work, I guess that's fine, I'm just curious if there's another pull-request/branch/something I'm missing? |
Glad to hear it works for you as well!
Weird, I looked at the original PR changes and |
No description provided.