Improve missing ELF symbol error message

Signed-off-by: Ivan Velickovic <[email protected]>
seL4 · Aug 27, 2024 · 1f46617 · 1f46617
1 parent bfcba00
commit 1f46617
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/tool/microkit/src/main.rs b/tool/microkit/src/main.rs
@@ -470,7 +470,15 @@ pub fn pd_write_symbols(
 
         for (setvar_idx, setvar) in pd.setvars.iter().enumerate() {
             let value = pd_setvar_values[i][setvar_idx];
-            elf.write_symbol(&setvar.symbol, &value.to_le_bytes())?;
+            let result = elf.write_symbol(&setvar.symbol, &value.to_le_bytes());
+            if let Err(err) = result {
+                return Err(format!(
+                    "{} in ELF '{}' for PD '{}'",
+                    err,
+                    pd.program_image.display(),
+                    pd.name
+                ));
+            }
         }
     }