Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving documentation for porting seL4 and making it up-to-date #222

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

Ivan-Velickovic
Copy link
Contributor

Work-in-progress changes - will try finish within the next couple days,

@Ivan-Velickovic Ivan-Velickovic changed the title Improving documentation for porting to seL4 and making it up-to-date Improving documentation for porting seL4 and making it up-to-date Jan 16, 2024
@june-andronick
Copy link
Contributor

@Ivan-Velickovic pinging you also here. This would be needed to the NCSC deliverable. Would you be able to finish it as soon as you can?

@Ivan-Velickovic Ivan-Velickovic force-pushed the update_porting branch 3 times, most recently from 43a536e to 9bfc142 Compare March 18, 2024 07:37
@Ivan-Velickovic Ivan-Velickovic marked this pull request as ready for review March 18, 2024 07:37
@Ivan-Velickovic Ivan-Velickovic force-pushed the update_porting branch 5 times, most recently from d74a165 to 7f6bf40 Compare March 18, 2024 08:18
@Ivan-Velickovic
Copy link
Contributor Author

@Ivan-Velickovic pinging you also here. This would be needed to the NCSC deliverable. Would you be able to finish it as soon as you can?

@june-andronick apologies for leaving it untouched for so long. I believe it is in a state to review now.

@Ivan-Velickovic Ivan-Velickovic requested a review from lsf37 March 18, 2024 08:18
projects/sel4/porting.md Outdated Show resolved Hide resolved
Copy link
Contributor

@june-andronick june-andronick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for doing this @Ivan-Velickovic . I have added a number of small nitpicks. I am not in a position to review the technical part though. If you're confident enough, then all good (and I'm approving in case it is the case). If you want a review of the technical part, please ask for some reviewer other than me :)

projects/sel4/porting.md Outdated Show resolved Hide resolved
projects/sel4/porting.md Outdated Show resolved Hide resolved
projects/sel4/porting.md Outdated Show resolved Hide resolved
projects/sel4/porting.md Outdated Show resolved Hide resolved
projects/sel4/porting.md Outdated Show resolved Hide resolved
projects/sel4/porting.md Outdated Show resolved Hide resolved
projects/sel4/porting.md Outdated Show resolved Hide resolved
projects/sel4/porting.md Outdated Show resolved Hide resolved
@Ivan-Velickovic
Copy link
Contributor Author

I'll wait a couple days for @lsf37 to review the technical side of things.

projects/sel4/porting.md Outdated Show resolved Hide resolved
projects/sel4/porting.md Outdated Show resolved Hide resolved
projects/sel4/porting.md Outdated Show resolved Hide resolved
Copy link
Member

@lsf37 lsf37 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with it from my side. Some minor suggestions above.

@june-andronick
Copy link
Contributor

@Ivan-Velickovic can this now be merged? Can you do it tomorrow (Tuesday)? Thanks!

@Ivan-Velickovic Ivan-Velickovic merged commit d8e0e29 into seL4:master Mar 25, 2024
8 checks passed
@Ivan-Velickovic
Copy link
Contributor Author

@Ivan-Velickovic can this now be merged? Can you do it tomorrow (Tuesday)? Thanks!

Done, if others want me to fix/change more of it I can make more PRs, but probably after March :)

@Ivan-Velickovic Ivan-Velickovic deleted the update_porting branch March 25, 2024 10:34
@june-andronick
Copy link
Contributor

Many thanks @Ivan-Velickovic !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants