-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improving documentation for porting seL4 and making it up-to-date #222
Conversation
@Ivan-Velickovic pinging you also here. This would be needed to the NCSC deliverable. Would you be able to finish it as soon as you can? |
43a536e
to
9bfc142
Compare
d74a165
to
7f6bf40
Compare
@june-andronick apologies for leaving it untouched for so long. I believe it is in a state to review now. |
7f6bf40
to
4197a91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for doing this @Ivan-Velickovic . I have added a number of small nitpicks. I am not in a position to review the technical part though. If you're confident enough, then all good (and I'm approving in case it is the case). If you want a review of the technical part, please ask for some reviewer other than me :)
4197a91
to
8d9f0eb
Compare
I'll wait a couple days for @lsf37 to review the technical side of things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with it from my side. Some minor suggestions above.
Signed-off-by: Ivan Velickovic <[email protected]>
8d9f0eb
to
6f970dc
Compare
@Ivan-Velickovic can this now be merged? Can you do it tomorrow (Tuesday)? Thanks! |
Done, if others want me to fix/change more of it I can make more PRs, but probably after March :) |
Many thanks @Ivan-Velickovic ! |
Work-in-progress changes - will try finish within the next couple days,