-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hardware: make title consistent in page/menus #214
Conversation
Used the term "Supported hardware platforms" (after discussion with Gerwin) for: the Hardware page title, the side menu and the landing page (table of content). Signed-off-by: June Andronick <[email protected]>
I have one comment (which might have already been discussed between you two), is it right to refer to the page as 'Hardware' since it also contains simulation platforms? I thought 'Supported Platforms' might be better since it covers both, but maybe it is too vague... |
That's a good point @Ivan-Velickovic . I'm happy to change to just "Supported platforms" everywhere if preferred. @lsf37 : thoughts? |
In principle yes, but we should make sure that the word "hardware" is mentioned prominently enough on the page so that Google returns it as top link for searches like "seL4 hardware". (It currently does, and the page title is just "supported platforms", so that seems to be Ok). |
Thanks @lsf37 . Does it mean you're ok with this PR? If so can you approve? Else let me know what you'd like to see happening before. Thanks! |
Signed-off-by: June Andronick <[email protected]>
Used the term "Supported hardware platforms" (after discussion with Gerwin) for: the Hardware page title, the side menu and the landing page (table of content).