Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: packed structs #202

Merged
merged 2 commits into from
Oct 18, 2023
Merged

style: packed structs #202

merged 2 commits into from
Oct 18, 2023

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Oct 17, 2023

Explain that structs must be packed (not contain any implicit padding).

Explain that structs must be packed (not contain any implicit padding).

Signed-off-by: Gerwin Klein <[email protected]>
processes/style-guide.md Outdated Show resolved Hide resolved
Copy link
Member

@Xaphiosis Xaphiosis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for me, but would be good to hear back from a systems person, as this guideline is mostly for them.

Copy link
Member

@axel-h axel-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@lsf37 lsf37 merged commit 7b0cc2c into master Oct 18, 2023
7 of 8 checks passed
@lsf37 lsf37 deleted the lsf37-patch-1 branch October 18, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants