accept PR number in thylint action #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an PR explicit PR number is passed, check out that PR, otherwise check out GITHUB_REF. This enables pull_request_target actions to provide an explicit target. Signed-off-by: Gerwin Klein <[email protected]>
GitHub turns this into INPUT_PR_NUM, which is consumed by `scripts/checkout.sh`. Signed-off-by: Gerwin Klein <[email protected]>
corlewis
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The thylint action produces a json file with annotations, and to display those annotations also for PRs from forks, we need the action to be triggered by
pull_request_target. For securitypull_request_targetprovides a differentGITHUB_REF(not to the head of the pull request as usual), so we will need to explicitly provide the PR target that needs to be checked out. To do this:scripts/checkout.shto acceptINPUT_PR_NUMand check out whatever that points topr_numarguments to the thylint action (which GitHub then turns inINPUT_PR_NUM)