simulation: fix expect script; add failure string #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the syntax for the expect script wasn't quite right; now fixed. - add a failure string for early abort where the builds support that. Signed-off-by: Gerwin Klein <[email protected]>
|
Have confirmed in docker that at least for |
wom-bat
approved these changes
Mar 15, 2024
| def sim_script(success: str, failure=None, timeout=1200): | ||
| """Return a script to run a simulation with timeout and expected success string. | ||
| Abort early on expected failure string.""" | ||
| fail_str = "%s {exit 1}" % failure if failure else "" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should now close #339 and fix the problem introduced in #340.