Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump actions and dependencies from node16 to node20 #322

Merged
merged 5 commits into from
Jan 28, 2024
Merged

Conversation

lsf37
Copy link
Member

@lsf37 lsf37 commented Jan 28, 2024

Implements #320.

Also bumps JS dependencies, which makes the diff huge. Two packages upgrade major versions: @actions/artifact and @actions/github. Checking the change log I don't expect any breakage, but this is essentially untested. Since these are difficult to test and non-critical I would merge this and see what happens. If it breaks, we can revert.

The main actions only see a patch version increase of @actions/core, which should definitely be non-breaking.

We're not using it on the seL4 repos any more, it never really took off.

Signed-off-by: Gerwin Klein <[email protected]>
@lsf37 lsf37 changed the base branch from master to remove_pr_queue January 28, 2024 00:31
@lsf37 lsf37 requested review from mbrcknl and axel-h January 28, 2024 00:37
@lsf37 lsf37 self-assigned this Jan 28, 2024
@lsf37 lsf37 added the dependencies Pull requests that update a dependency file label Jan 28, 2024
@lsf37
Copy link
Member Author

lsf37 commented Jan 28, 2024

The dependencies have whitespace and shell warnings. We should ignore these since they're 3rd party code.

Copy link
Member

@mbrcknl mbrcknl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

lsf37 added 4 commits January 28, 2024 11:47
- @actions/artifact: ^1.1.1 -> ^2.1.0
- @actions/core: ^1.10.0 -> 1.10.1
- @actions/github: ^5.1.1 -> ^6.0.0"

Checking the change logs, I'm not expecting any relevant API changes
for the bv-trigger action. Artifacts are now available earlier, so it
is possible that we no longer need the await-remote-artifacts action.

Signed-off-by: Gerwin Klein <[email protected]>
Bump dependencies together with upgrade to node20.

- @actions/core: ^1.10.0 -> ^1.10.1
- @actions/github: 5.1.1 -> 6.0.0

No breaking API changes expected.

Signed-off-by: Gerwin Klein <[email protected]>
This bumps @actions/core from ^1.10.0 to ^1.10.1. No breaking API
changes.

Signed-off-by: Gerwin Klein <[email protected]>
GitHub has started to produce warnings for node16 actions.

Signed-off-by: Gerwin Klein <[email protected]>
Base automatically changed from remove_pr_queue to master January 28, 2024 01:48
@lsf37 lsf37 merged commit 564267b into master Jan 28, 2024
5 of 7 checks passed
@lsf37 lsf37 deleted the node-js-20 branch January 28, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants