Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

platforms: add Pine64 Star64 #283

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

platforms: add Pine64 Star64 #283

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
17951c4
platforms: add Pine64 Star64
Ivan-Velickovic Aug 22, 2023
0f4f87a
Merge branch 'master' into star64
lsf37 Oct 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions seL4-platforms/platforms.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,14 @@ platforms:
req: [hifive] # , hifive1]
march: rv64imac

STAR64:
arch: riscv
modes: [64]
smp: [64]
platform: star64
req: [star64]
march: rv64imac
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what march does exactly here, march: rv64gcb would be more accurate for the Star64. The only use of march I can see is here

ci-actions/seL4-platforms/platforms.py

Lines 183 to 192 in 607634d

def getISA(self, mode: int) -> str:
"""Return the ISA for this platform"""
if self.arch == "x86":
return {32: "IA32", 64: "x86_64"}[mode]
if self.arch == "riscv":
return {32: "RC32IMAC", 64: "RV64IMAC"}[mode]
return self.march.capitalize()
, where it seems to be ignoring march anyways.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be wrong, but I think the only remaining use of march is for grouping in CI matrices. We could try to eliminate it and see what happens..


SABRE:
arch: arm
modes: [32]
Expand Down