add simulation tests for RISCVVIRT32 #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axel-h
force-pushed
the
patch-axel-7
branch
3 times, most recently
from
cc1c508 to
390a7c6
Compare
|
This looks fine from my side, but it will be part of the build matrix for simulation immediately when we merge it (unless we filter it out specifically), so we should make sure first that the build work. One way to not have it in the build matrix immediately (for simulation) would be to comment out the |
|
The build still fails locally for me due to a non-trivial issue. But I lack time to investigate it, so please don't merge. Will make it a draft again. |
axel-h
force-pushed
the
patch-axel-7
branch
3 times, most recently
from
61bd681 to
9bfe45a
Compare
Signed-off-by: Axel Heider <[email protected]>
|
Link check fails because https://deb.debian.org/debian/pool/main/d/devscripts/devscripts_2.23.3.tar.xz got replaced by https://deb.debian.org/debian/pool/main/d/devscripts/devscripts_2.23.4.tar.xz now. See #287 |
Ivan-Velickovic
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #209 to also add support for the 32-bit version of qemu-riscv-virt. It's currently still in draft state, as building fail for me locally. However, that might not be a blocker to add it to the action already, so it can be used once the issues are fixed.
see also: seL4/seL4#951