Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

camkes-vm-apps: use empty list #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

axel-h
Copy link
Member

@axel-h axel-h commented Mar 13, 2023

@@ -87,7 +87,7 @@ assembly {
"0x48000000:27" //RAM
];
vm1.irqs = [];
vm1.dtb = dtb([{}]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this instead be addressed by allowing the template that uses this config option to accept an unset .dtb config setting?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this instead be addressed by allowing the template that uses this config option to accept an unset .dtb config setting?

I'd make this a separate PR then. Maybe we could just set dtb([]) in the defaults, so this does not have to be set explicitly.
For now, this PR here is just for some more test coverage for seL4/camkes-tool#129, it does not have to get merged.
I'd really like to see the empty list support from seL4/camkes-tool#129 getting merged. It is quite convenient for development, when adding an removing entries there. You don't run into an error, if the list turns out to be empty because of commented out elements.

@axel-h axel-h force-pushed the patch-axel-1 branch 8 times, most recently from d36dcf8 to d617b48 Compare January 30, 2024 11:32
@axel-h axel-h force-pushed the patch-axel-1 branch 2 times, most recently from 61f46d8 to 507fd1d Compare January 31, 2024 23:30
Signed-off-by: Axel Heider <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants