Skip to content

Commit

Permalink
Add flake8-fixme (#294)
Browse files Browse the repository at this point in the history
* Add addon

* Remove fixme

* Add addon

* Remove fixme

* Fix bug
  • Loading branch information
fealho authored Nov 23, 2021
1 parent b81f91a commit 55e8056
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 0 additions & 2 deletions copulas/multivariate/vine.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,8 +248,6 @@ def train_vine(self, tree_type):

def get_likelihood(self, uni_matrix):
"""Compute likelihood of the vine."""
# TODO: explain what this is supposed to do and make it work
# TODO: Alternatively, remove it.
num_tree = len(self.trees)
values = np.empty([1, num_tree])

Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
'flake8-debugger>=4.0.0,<4.1',
'flake8-mock>=0.3,<0.4',
'flake8-mutable>=1.2.0,<1.3',
'flake8-fixme>=1.1.1,<1.2',
'pep8-naming>=0.12.1,<0.13',
'dlint>=0.11.0,<0.12',
'flake8-docstrings>=1.5.0,<2',
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/multivariate/test_gaussian.py
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ def test_sample_constant_column(self):

# Check
assert result.shape == (5, 2)
results = result[~result.is()].all()
results = result[~result.isna()].all()
assert results.all()
assert result.loc[:, 0].equals(pd.Series([1.0, 1.0, 1.0, 1.0, 1.0], name=0))

Expand Down

0 comments on commit 55e8056

Please sign in to comment.