Updates search endpoints to use the new observed column #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should this condition also apply to the other endpoints? e.g. the carton/program search, or target search by catalogid? |
Updated to include carton/program searches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #29. It updates the
append_pipesquery to also return the newhas_been_observedcolumn, and allows for filtering results based on the new column. The default is set to True, to always filter for only observed targets. It updates the cone search (/query/cone) endpoint and the main search (/query/main) endpoint, to use the new observed column.Currently requires the latest main of
sdssdbto use.