Added target_by_sdss_id_list endpoint #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havok2063
reviewed
Mar 1, 2024
python/valis/db/queries.py
Outdated
Comment on lines
175
to
196
| def get_targets_by_sdss_id_list(sdss_id_list: list = []) -> peewee.ModelSelect: | ||
| """ Perform a search for SDSS targets on vizdb.SDSSidStacked based on a list if sdss_ids. | ||
|
|
||
| Perform a search for SDSS targets from a list of sdss_id values, | ||
| using the peewee ORM in the vizdb.SDSSidStacked table. | ||
| We return the peewee ModelSelect directly here so it can be | ||
| easily combined with other queries, if needed. | ||
|
|
||
| In the route endpoint itself, remember to return wrap this in a list. | ||
|
|
||
| Parameters | ||
| ---------- | ||
| sdss_id_list : List[int] | ||
| list of sdss_id values | ||
|
|
||
| Returns | ||
| ------- | ||
| peewee.ModelSelect | ||
| the ORM query | ||
| """ | ||
|
|
||
| return vizdb.SDSSidStacked.select().where(vizdb.SDSSidStacked.sdss_id.in_(sdss_id_list)) |
There was a problem hiding this comment.
This function isn't that different than the existing get_targets_by_sdss_id. Can you consolidate these two into a single function.
havok2063
reviewed
Mar 1, 2024
|
@mtaghiza can you edit the description of the PR with what this is, for transparency and posterity? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new post request endpoint to get targets by a list of sdss_ids, using a body parameter. This is for when we add support for uploading a file to the front end. Updates the
get_targets_by_sdss_idendpoint to accept a list of sdss_ids.