Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 4CA41F Irish Air Corps C295 reg 284 #484

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

natexornate
Copy link
Contributor

Added Irish Air Corps' second C-295, 284. The first, 285 was already in the DB.

Checklist before requesting a review

  • [x ] I have performed a self-review of my code.
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers.

@github-actions github-actions bot added the planes Plane info label Mar 14, 2024
Copy link
Collaborator

@dziban303 dziban303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The URL field should go to, for example, a Wikipedia page. For the Irish Air Corps we've been using https://www.military.ie/en/who-we-are/air-corps
Photos go in plane_images.csv in the format:

4CA41F,https://cdn.jetphotos.com/full/5/592417_1709898367.jpg,,,

@github-actions github-actions bot added the images Plane images label Mar 14, 2024
@natexornate
Copy link
Contributor Author

Whoops! Fixed it, think it's correct now.

Copy link
Collaborator

@dziban303 dziban303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks!

@dziban303 dziban303 merged commit 65c6e73 into sdr-enthusiasts:main Mar 14, 2024
3 checks passed
@natexornate natexornate deleted the air-corps-284 branch March 14, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
images Plane images planes Plane info
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants