Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hc updates #84

Merged
merged 8 commits into from
Nov 9, 2023
Merged

Hc updates #84

merged 8 commits into from
Nov 9, 2023

Conversation

fredclausen
Copy link
Member

Not tested / not ready to merge yet, but this update does the following:

  • Removes the healthcheck check for UAT traffic being received
  • Creates a new service that does the same thing, and will log to stdout if there is hasn't been any traffic received

The impetus for this change is that dump978 will flag itself as unhealthy if there is no UAT traffic received. However, UAT traffic is so sporadic, and there are significant times of the day when you won't reasonably expect to get it (over-night for example), and on bad weather days when the small planes aren't flying.

Being marked as unhealthy could cause unnecessary restarts of the container if autoheal is being used, and if that's occurring then things like autogain runs will be messed up. I think it's a better option to just log out if there is no traffic received and let the user decide if it's a real issue.

Potential changes to this:

  • Increase the check interval from 15 minutes to perhaps a few hours
  • Consider time of day when deciding to log out

@fredclausen fredclausen requested a review from kx1t November 9, 2023 15:54
@fredclausen fredclausen merged commit 223d255 into main Nov 9, 2023
11 checks passed
@fredclausen fredclausen deleted the hc-updates branch November 9, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants