Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build container in one shot #954

Merged
merged 7 commits into from
Oct 1, 2023
Merged

Conversation

iakat
Copy link
Contributor

@iakat iakat commented Sep 7, 2023

This builds acarshub in one shot, not needing 3 dockerfiles (+upstream's)

Tested n=1 on my Pi (my repo branch=main has a github actions to build it)

This leaves out the BUILD_EXTRA which you would need to pass at build time to populate with the CI run number.

I also kept getting

[webapp      ] 2023/09/07 00:46:45 Traceback (most recent call last):
[webapp      ] 2023/09/07 00:46:45   File "/webapp/SafeScheduler.py", line 33, in _run_job
[webapp      ] 2023/09/07 00:46:45     super()._run_job(job)
[webapp      ] 2023/09/07 00:46:45   File "/usr/local/lib/python3.11/dist-packages/schedule/__init__.py", line 172, in _run_job
[webapp      ] 2023/09/07 00:46:45     ret = job.run()
[webapp      ] 2023/09/07 00:46:45           ^^^^^^^^^
[webapp      ] 2023/09/07 00:46:45   File "/usr/local/lib/python3.11/dist-packages/schedule/__init__.py", line 693, in run
[webapp      ] 2023/09/07 00:46:45     ret = self.job_func()
[webapp      ] 2023/09/07 00:46:45           ^^^^^^^^^^^^^^^
[webapp      ] 2023/09/07 00:46:45   File "/webapp/acarshub.py", line 467, in init_listeners
[webapp      ] 2023/09/07 00:46:45     if not thread_html_generator.is_alive():
[webapp      ] 2023/09/07 00:46:45            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[webapp      ] 2023/09/07 00:46:45 AttributeError: 'EventletThread' object has no attribute 'is_alive'

so switched the check for thread_html_generator as it becomes a engineio.async_drivers.eventlet.EventletThread which does not have is_alive -- but has a g attribute. https://github.com/miguelgrinberg/python-engineio/blob/main/src/engineio/async_drivers/eventlet.py

@fredclausen fredclausen marked this pull request as ready for review October 1, 2023 16:15
@fredclausen
Copy link
Member

Thank you for this @katlol!

@fredclausen fredclausen merged commit ef74e5b into sdr-enthusiasts:main Oct 1, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants