-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some DocBlocks, comments, formatting because why not try? #1
base: master
Are you sure you want to change the base?
Conversation
@@ -1,6 +1,6 @@ | |||
composer.phar | |||
vendor/ | |||
|
|||
.idea* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its actually a good idea to put this in your global gitignore, instead of the project one, as not everyone uses phpstorm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would it matter if someone wasn't using phpStorm? It just wouldn't do anything. What if someone was using phpStorm and didn't have this in their global gitignore? (<= Rhetorical question)
I don't see any harm having it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It adds stuff to the gitignore that isn't necessary.
project gitignores are meant to house things that should be ignored for that specific project
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you are being overly critical. I will restate my original opinion, I don't see any harm having it here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not being critical at all, i'm simply offering an point of view that is commonly accepted by the open source community.
https://github.com/laravel/framework/blob/4.2/.gitignore
https://github.com/symfony/symfony/blob/2.7/.gitignore
just two of the biggest OS php projects out there, as reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noted, thank you
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa! I honestly didn't know (or forgot) about a global gitignore file. This is news to me and as Eric said, noted.
I can go either way.
Thanks for the input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Theres a really good repo by github, https://github.com/github/gitignore/ that's got a lot of good gitignore information.
They list all of the IDE and system specific ones in the Global directory.
Its a pretty good resource.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah we cloned it to the SDPHP Repo sometime ago to bring it to peoples attention
You guys should look at switching to following PSR-2 |
A big part of why I threw this out there is to get a discussion going like this. Thank you again. |
Yeah, good to start the process of following standards easier though. It wont fit in the scope of this PR to migrate to the PSR-2 standard, but, it would definitely make it easier for newcomers to hop on the project. |
No description provided.