Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Paths #22

Merged
merged 161 commits into from
Jan 5, 2022
Merged

Global Paths #22

merged 161 commits into from
Jan 5, 2022

Conversation

sdl60660
Copy link
Owner

@sdl60660 sdl60660 commented Jan 5, 2022

Changes

This incorporates the new MERIT River Runner API for generating global flowpaths (more information here).

Additionally, addresses a whole host of issues associated with expanding globally, given that there were a lot of assumptions made in building the US-only version that do not hold here. A partial list is documented here:

Some features of notes besides geographic expansion:

  • Fixes the clipped beginnings/ends of paths that came about as a result of path smoothing
  • Expands stopping feature list significantly, particularly for ocean features, and incorporates inland lakes into navigation path
  • Adds a modal for suggesting names when missing (name data coverage is lacking significantly on non-US paths, relatively)
  • Fixes disjointedness from flight to path start by accurately gathering terrain-exaggeration-adjusted elevation data prior to run start

Issues of Concern

Note: due to some lingering issues, this version is considered in beta and will not yet be merged into main. It will also exist on a separate URL, here: https://river-runner-global.samlearner.com/, while the original US-only version persists on the original URL, here: https://river-runner.samlearner.com/. Some of these issues will be addressed in the front-end in this repo, others are issues being addressed in the underlying data/API. A few of these issues are notably worse in the global app than in the US-only app, for US flowpaths, which is part of the rationale of maintaining both, for the time being.

A partial list of issues being addressed:

  • Incomplete feature name coverage, particularly outside of the United States
  • Issues with over-grouping on feature names for paths that run through large inland lakes (many of these are documented here: Potential Path Issues ksonda/global-river-runner#25)
  • Paths may not reflect true river paths when affected by engineered features such as dams, canals, and conduits (the Chicago Sanitary and Ship Canal is a notable example of this)
  • The current Mercator projection is not ideal for the global view. Currently, it's the only available Mapbox GL projection suitable for this application, but that is due to change soon with a release of a 3D globe view. When this feature is ready from Mapbox, it will be incorporated into the app.

…f the issues with the feature grouping/stop points a lot more, as well as the hangs on the navigation/control panels)
…issues, particulary with targets not on screen at the time of search, which were falling back to a different, very bad elevation calculation
…y fixed the zoom issue and seem to have a solution on flight/start mismatch by doing a pre-calculation flyTo to render tiles for elevation queries.
…e with lower ones, updated smoothing coefficient and target pitch, updated how unidentified features display on the navigation box UI
…ot yet final, it's not hooked up to a db yet and there's no mobile solution yet).
… is being thrown off somewhere in the underlying merit data. This is a problem for some other paths that run through very large inland features, too, but this seems like it will be the most frequent/noticeable manifestation of it, so until it is resolved, I will leave this method in place
…lding layer, though I don't think it'll really make any sense at current zoom levels
@vercel
Copy link

vercel bot commented Jan 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

river-runner-global – ./

🔍 Inspect: https://vercel.com/samlearner/river-runner-global/Fu2nuRcJEpK6p3saCrN6WsJ8zGf2
✅ Preview: https://river-runner-global.vercel.app

river-runner – ./

🔍 Inspect: https://vercel.com/samlearner/river-runner/S4YPQ1YLD9i4GZmag31XVpBhDSi5
✅ Preview: https://river-runner-git-global-samlearner.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant