-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coroutinize http client code #2429
Open
xemul
wants to merge
28
commits into
scylladb:master
Choose a base branch
from
xemul:br-http-client-coroutinize
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
797dc34
http/client: Coroutinize connection::write_body
xemul 32365d4
http/client: Coroutinize connection::maybe_wait_for_continue
xemul e8df44b
http/client: Coroutinize connection::send_request_head
xemul dd51c2c
http/client: Coroutinize connection::recv_reply
xemul ad9833d
http/client: Restore indentation of connection::recv_reply
xemul 9b46ea5
http/client: Coroutinize connection::do_make_request
xemul 86d6a8b
http/client: Restore indentation of connection::do_make_request
xemul 14e3efc
http/client: Squash maybe_wait_for_continue into do_make_request
xemul c5a63be
http/client Squash send_request_head into do_make_request
xemul 9b473bf
http/client: Coroutinize connection::make_request
xemul ffacf24
http/client: Coroutinize connection::close
xemul cb1b4b6
http/client: Restore indentation of connection::close
xemul bd36cf3
http/client: Coroutinize client::make_connection
xemul bdfdf16
http/client: Restore indentation of client::make_connection
xemul 2d1550e
http/client: Coroutinize client::put_connection
xemul 215e024
http/client: Coroutinize client::shrink_connections
xemul 88de135
http/client: Restore indentation of client::shrink_connections
xemul b10c8b6
http/client: Coroutinize client::set_maximum_connections
xemul 685f6f2
http/client: Coroutinize client::with_connection
xemul 200ea10
http/client: Coroutinize client::with_new_connection
xemul 4250bca
http/client: Coroutinize client::close
xemul 688ac04
http/client: Restore indentation of client::close
xemul 3e22a25
http/client: Coroutinize client::do_make_request
xemul 02df7b8
http/client: Sanitize client::do_make_request unexpected body logging
xemul 4dfb090
http/client: Coroutinize client::get_connection
xemul 539fa2a
http/client: Restore indentation of client::get_connection
xemul 3231966
http/client: Coroutinize client::do_make_request (con-less overload)
xemul 67134fd
http/client: Restore indentation of client::do_make_request overload
xemul File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
heh, i believe Avi would like this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has less than 4 closing corner braces in a row, so not that bad
Meanwhile in scylla (scroll right):
😱
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah, i meant, he always prefers an explicit return type. this one make it more explicit. so..