Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up usage of _is_na, _is_true and _is_false #380

Open
grst opened this issue Jan 29, 2023 · 0 comments
Open

clean up usage of _is_na, _is_true and _is_false #380

grst opened this issue Jan 29, 2023 · 0 comments

Comments

@grst
Copy link
Collaborator

grst commented Jan 29, 2023

Description of feature

Since #356, we have additional guarantees about the data types in .obsm["airr"] and there is no danger that AnnData changes the data type of a pandas column anymore during save/load. Therefore, we can get rid of most instances of _is_na, _is_true, and _is_false checks. The only remaining instances should be in the IO module sanitizing input before it is stored in AnnData.

Cleaning this up should improve performance, and make the code more legible.

When doing so, tests should be added that everything still works as expected when creating AirrCell objects from data that does contain string representations of NaN/True/False/...

@grst grst mentioned this issue Jan 29, 2023
48 tasks
@grst grst added this to scirpy-dev May 28, 2024
@grst grst moved this to prio2 in scirpy-dev May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: prio2
Development

No branches or pull requests

1 participant