Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring group_abundance. #232

Open
3 tasks
grst opened this issue Jan 13, 2021 · 2 comments · May be fixed by #463
Open
3 tasks

Refactoring group_abundance. #232

grst opened this issue Jan 13, 2021 · 2 comments · May be fixed by #463

Comments

@grst
Copy link
Collaborator

grst commented Jan 13, 2021

The current group_abundance function is relatively slow.
Also I don't like the name too much.

barplot or stackedbarplot is better. x, y and color are better argument names.

Maybe this could even be merged upstream into scanpy.

See also:
https://sc-dandelion.readthedocs.io/en/master/api.html#module-dandelion.plotting

@grst
Copy link
Collaborator Author

grst commented Nov 26, 2021

Related #186
Related #247

@grst grst changed the title Consider refactoring group_abundance. Refactoring group_abundance. Jan 19, 2023
@grst
Copy link
Collaborator Author

grst commented Jan 19, 2023

This is a priority now, as with the new data structure, some poor design choices surface.
But we can do this after merging #327.

@grst grst added this to scirpy-dev May 28, 2024
@grst grst moved this to In progress in scirpy-dev May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

1 participant