Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalizing names #47

Open
6 tasks
ivirshup opened this issue May 15, 2023 · 0 comments · May be fixed by #54
Open
6 tasks

Finalizing names #47

ivirshup opened this issue May 15, 2023 · 0 comments · May be fixed by #54
Labels
API enhancement New feature or request P0‼️ High priority
Milestone

Comments

@ivirshup
Copy link
Member

ivirshup commented May 15, 2023

Description of feature

We should finalize naming for things. I'm starting a list here of things to resolve

  • GeneRangesFilter -> GeneRangeFilter (since it only takes a single range)
  • CanonicalFilter -> ???
  • genes(cols=...) -> genes(columns=...) – Just to be more consistent. Could go the other way and use cols everywhere.
  • What are the canonical strand names? +, - I assume?

Pushing to next release:

  • GeneRangeFilter + TxRangeFilter + ExonFilter or all one RangeFilter as done in bioconductor?
  • gf.ensembl.annotation Do we still want to call this an annotation? I named the function when the package was called genomic-annotations
@ivirshup ivirshup added the enhancement New feature or request label May 15, 2023
@ivirshup ivirshup added this to the 0.1.0 milestone May 15, 2023
@ivirshup ivirshup linked a pull request Sep 20, 2023 that will close this issue
4 tasks
@ivirshup ivirshup added P0‼️ High priority API labels Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request P0‼️ High priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant