Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(chore): clean up use of spmatrix and sparray #1649

Open
ilan-gold opened this issue Sep 4, 2024 · 0 comments · May be fixed by #1767
Open

(chore): clean up use of spmatrix and sparray #1649

ilan-gold opened this issue Sep 4, 2024 · 0 comments · May be fixed by #1767
Assignees
@ilan-gold
Labels
enhancement
Milestone
0.12.0

Comments

@ilan-gold
Copy link
Contributor

ilan-gold commented Sep 4, 2024 •
edited
Loading

Please describe your wishes and possible alternatives to achieve the desired result.

At the moment, we use a lot of spmatrix and sparray as types where they shouldn't be used. We should clean up the types and do the promised deprecation on instance checking: https://github.com/scverse/anndata/pull/1616/files#diff-3b4874efa9bc9a522fa0cc5a88c69e233d7b46f2993331162bab12c4a6371bdcR70-R74

We should also look for other faulty instance checks
@ilan-gold ilan-gold added this to the 0.12.0 milestone Sep 4, 2024
@ilan-gold ilan-gold self-assigned this Sep 4, 2024
@ilan-gold ilan-gold linked a pull request Nov 14, 2024 that will close this issue
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ilan-gold ilan-gold

Labels
enhancement
Projects
None yet
Milestone
0.12.0
Development

Successfully merging a pull request may close this issue.

(chore): tighten spmatrix usage scverse/anndata
1 participant
@ilan-gold