Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potentially flaky benchmark #1513

Open
2 of 3 tasks
ilan-gold opened this issue Jun 4, 2024 · 2 comments
Open
2 of 3 tasks

Potentially flaky benchmark #1513

ilan-gold opened this issue Jun 4, 2024 · 2 comments

Comments

@ilan-gold
Copy link
Contributor

Please make sure these conditions are met

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of anndata.
  • (optional) I have confirmed this bug exists on the master branch of anndata.

Report

It seems that one of the benchmarks could be flaky: https://github.com/scverse/anndata/pull/1119/checks?check_run_id=25740561547 because I changed almost nothing except a different benchmark name and then it reverted to passing: https://github.com/scverse/anndata/pull/1119/checks?check_run_id=25777680830. The benchmark is readwrite.H5ADReadSuite.track_read_full_memratio('pbmc3k')

Versions

N/A
@ilan-gold
Copy link
Contributor Author

https://github.com/scverse/anndata/pull/1119/checks?check_run_id=25779040354 Now back to failing...maybe it's this branch then

@github-actions github-actions bot added the stale label Aug 5, 2024
@flying-sheep flying-sheep removed the stale label Aug 5, 2024
@scverse scverse deleted a comment from github-actions bot Aug 5, 2024
@flying-sheep
Copy link
Member

The benchmarks in general seem to be flaky.

We should check out the machine together and see how we can tune it to be more consistent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants