fix(scully-plugin-puppeteer): change noew reseved 'onCustomEvent' to …

…'onRenderReady' to prevent the default 25 seconds timeout (#1593)
scullyio · Jun 13, 2022 · 3dea6c4 · 3dea6c4
1 parent 5243480
commit 3dea6c4
Show file tree

Hide file tree

Showing 3 changed files with 42 additions and 66 deletions.
diff --git a/libs/plugins/scully-plugin-playwright/src/lib/plugins-scully-plugin-playwright.ts b/libs/plugins/scully-plugin-playwright/src/lib/plugins-scully-plugin-playwright.ts
@@ -51,7 +51,7 @@ export const playwrightRenderer = async (route: HandledRoute): Promise<string> =
     }
 
     /** this will be called from the browser, but runs in node */
-    await page.exposeFunction('onCustomEvent', () => {
+    await page.exposeFunction('onRenderReady', () => {
       resolve();
     });
 
@@ -79,7 +79,7 @@ export const playwrightRenderer = async (route: HandledRoute): Promise<string> =
       /** set "running" mode */
       window['ScullyIO'] = 'running';
       window.addEventListener('AngularReady', () => {
-        window['onCustomEvent']();
+        window['onRenderReady']();
       });
     });
 

diff --git a/libs/plugins/scully-plugin-puppeteer/src/lib/plugins-scully-plugin-puppeteer.ts b/libs/plugins/scully-plugin-puppeteer/src/lib/plugins-scully-plugin-puppeteer.ts
@@ -96,7 +96,7 @@ export const puppeteerRender = async (route: HandledRoute): Promise<string> => {
     }
 
     /** this will be called from the browser, but runs in node */
-    await page.exposeFunction('onCustomEvent', () => {
+    await page.exposeFunction('onRenderReady', () => {
       resolve();
     });
 
@@ -125,7 +125,7 @@ export const puppeteerRender = async (route: HandledRoute): Promise<string> => {
       /** set "running" mode */
       window['ScullyIO'] = 'running';
       window.addEventListener('AngularReady', () => {
-        window['onCustomEvent']();
+        window['onRenderReady']();
       });
     });
 

diff --git a/package-lock.json b/package-lock.json