Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.10+ compatibility #26

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Python 3.10+ compatibility #26

merged 2 commits into from
Sep 26, 2023

Conversation

ghost
Copy link

@ghost ghost commented Sep 25, 2023

Thanks for your great work on this project. My team are trying to make the most of it but running into snags with the dependencies since they are not compatible with modern versions of python.

I hope you consider the pull request below to rectify this problem.

Thanks


Problem statement

Poetry builds for newer versions of python fail owing to PEP 517 build rules and unsupported versions of certain libraries. This makes this project very difficult to install in more modern environments with newer co-dependencies.

Change summary

It took quite a bit of trial and error but this PR is what I came up with to solve this problem by making the requirements more dynamic and making the versions more dependent on the specific version of python being used - with a couple of exceptions listed below:

  • removing and replacing the lock file.
  • numpy >1.22 -> this change was made because the project readme claims to support only python 3.8+, but numpy versions < 1.22 are not compatible with higher versions of python thus this must be bumped to 1.22 altogether.
  • pyyaml >= 6.0.0 -> New major version of pyyaml required to not break builds using python 3.10+. This change required a very minor code change in the load method used in one of the unit tests, so overall must be bumped to 6.0

tests

  • Tested poetry install and poetry run python -m unittest in python 3.8, 3.9, 3.10 and 3.11. All are passing.

@ghost ghost changed the title Python 3.9+ compatibility Python 3.10+ compatibility Sep 26, 2023
@scuervo91
Copy link
Owner

Thank you very much for contributing to the Repo

@scuervo91 scuervo91 merged commit 6f632cd into scuervo91:main Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants