Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: ISSUE #938 Providing multiple classes in positionClass #983

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

prajwal-np
Copy link

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.11 ⚠️

Comparison is base (815e1dd) 55.70% compared to head (c602965) 55.59%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #983      +/-   ##
==========================================
- Coverage   55.70%   55.59%   -0.11%     
==========================================
  Files          19       19              
  Lines         508      509       +1     
  Branches       88       88              
==========================================
  Hits          283      283              
  Misses        216      216              
- Partials        9       10       +1     
Impacted Files Coverage Δ
src/lib/overlay/overlay.ts 87.50% <100.00%> (+0.54%) ⬆️
src/app/home/home.component.ts 58.57% <0.00%> (-1.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@prajwal-np
Copy link
Author

@scttcper please review this PR and let me know if the solution is acceptable or not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant