#711 + #713 remove num chunks from public input; relax the constraints for the dummy chunk proofs to avoid dummy chunk proofgen time #712

zhenfeizhang · 2023-08-02T16:44:12Z

Description

new features
- remove num chunks from public input;
- relax the constraints for the dummy chunk proofs to avoid dummy chunk proofgen time
integrated fixes in

Issue Link

macro issue to track bugs in #670 #698
- Remove num_chunks from public input #711
- relax the constraints for the dummy chunk proofs to avoid dummy chunk proofgen time #713

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Rationale

[design decisions and extended information]

How Has This Been Tested?

real prover over dynamic number of mock chunks

* add range table * replace Range256Table of rlp_circuit_fsm * replace u16_table of tx_circuit * use TableColumn * add type alias * use type alias * annotate lookup column

prune debug prints and lint

* speedup ci using verify_at_rows * use verify_at_rows to speedup super circuit ci tests

Co-authored-by: kunxian xia <[email protected]>

kunxian-xia · 2023-08-03T13:15:56Z

@zhenfeizhang The pr #686 is still buggy. And can you change the base branch of these sub-PRs to this branch? This will make sure that all changes in the sub-PRs are included in this PR.

zhenfeizhang · 2023-08-03T14:20:37Z

@zhenfeizhang The pr #686 is still buggy. And can you change the base branch of these sub-PRs to this branch? This will make sure that all changes in the sub-PRs are included in this PR.

Oh missed that comment. will address

aggregator/README.md

aggregator/src/core.rs

kunxian-xia · 2023-08-04T13:28:37Z

Only the last comment is potential vulnerability while the others are primarily related to docs.

…scroll-tech/zkevm-circuits into 711-remove-num_chunks-from-public-input

kunxian-xia

One last problem is that is_final cells are not exported and not enforced to be true.

zhenfeizhang · 2023-08-04T15:37:30Z

One last problem is that is_final cells are not exported and not enforced to be true.

fixed in 2401449

aggregator/README.md

aggregator/figures/architecture.jpg

aggregator/src/aggregation/rlc/gates.rs

* address additional comments on #712 * minor:typo * address comments: editorial * Update aggregator/README.md Co-authored-by: Haichen Shen <[email protected]> --------- Co-authored-by: Haichen Shen <[email protected]>

zhenfeizhang and others added 15 commits August 1, 2023 10:46

partiall address review comments of #670

f3cc71f

disable disable_proof_agg by default

1f173b8

fix soundness issues with data hash

2aeb3e0

add fixed cells for chunk_is_valid

ac9c4ee

fix typo

38d14c1

well... need morning coffee

08f21d0

typo in readme

9c84798

fix soundness issue in is_smaller_than

845ee0c

[feat] unify u8 u16 lookup table (#694)

311b6dc

* add range table * replace Range256Table of rlp_circuit_fsm * replace u16_table of tx_circuit * use TableColumn * add type alias * use type alias * annotate lookup column

opt min_num_rows_block in poseidon_circuit (#700)

d6eb833

prune debug prints and lint

speedup ci using verify_at_rows (#703)

5658bc5

* speedup ci using verify_at_rows * use verify_at_rows to speedup super circuit ci tests

update super circuit row estimation API (#695)

3097221

remove num_of_chunks in aggregation circuit's instance column (#704)

8319ade

Co-authored-by: kunxian xia <[email protected]>

fix: lost tx_type when doing type conversion (#710)

29eb9c3

fix condition (#708)

818dc78

zhenfeizhang linked an issue Aug 2, 2023 that may be closed by this pull request

Remove num_chunks from public input #711

Closed

github-actions bot added crate-bus-mapping crate-eth-types crate-zkevm-circuits labels Aug 2, 2023

zhenfeizhang added 6 commits August 2, 2023 15:49

gates for zero checks

8a0a908

statement 1 is correct

cb0f622

reenable statements 3,6,7

539d63c

reenable statement 4

8182446

everything seems to work again

6e69d1e

update aggregation test accordingly

dd9d01f

zhenfeizhang marked this pull request as ready for review August 2, 2023 20:39

update spec

ec95160

zhenfeizhang changed the title ~~711 remove num chunks from public input~~ 711 + 713 remove num chunks from public input; relax the constraints for the dummy chunk proofs to avoid dummy chunk proofgen time Aug 2, 2023

zhenfeizhang self-assigned this Aug 2, 2023

minor clean up

4154a6b

zhenfeizhang requested review from kunxian-xia and lispc August 3, 2023 12:50

fix decompose function

00ba5ff

zhenfeizhang mentioned this pull request Aug 4, 2023

Fix chunk is padding circuit #686

Closed

4 tasks

zhenfeizhang and others added 3 commits August 3, 2023 20:26

update figures

5325f45

clean up

4f6eac8

Merge branch 'develop' into 711-remove-num_chunks-from-public-input

f58aa57

kunxian-xia requested changes Aug 4, 2023

View reviewed changes

kunxian-xia and others added 3 commits August 4, 2023 22:19

Merge branch 'develop' into 711-remove-num_chunks-from-public-input

0446a28

address comments

246b471

Merge branch '711-remove-num_chunks-from-public-input' of github.com:…

e491a92

…scroll-tech/zkevm-circuits into 711-remove-num_chunks-from-public-input

kunxian-xia self-requested a review August 4, 2023 15:20

kunxian-xia reviewed Aug 4, 2023

View reviewed changes

zhenfeizhang added 2 commits August 4, 2023 11:34

add is_final checks

2401449

update readme

9da7fc3

This was referenced Aug 4, 2023

Fix soundness bug in aggregator pi datahash #691

Closed

partiall address review comments of #670 #699

Closed

zhenfeizhang added 2 commits August 4, 2023 13:16

constraint hash input length

80861c1

fix clippy

aa79cc8

kunxian-xia approved these changes Aug 4, 2023

View reviewed changes

lispc merged commit 8f3e82a into develop Aug 4, 2023

lispc deleted the 711-remove-num_chunks-from-public-input branch August 4, 2023 17:57

icemelon reviewed Aug 4, 2023

View reviewed changes

aggregator/README.md Show resolved Hide resolved

aggregator/figures/architecture.jpg Show resolved Hide resolved

aggregator/src/aggregation/rlc/gates.rs Show resolved Hide resolved

aggregator/src/aggregation/rlc/gates.rs Show resolved Hide resolved

zhenfeizhang added a commit that referenced this pull request Aug 4, 2023

address additional comments on #712

fbda778

zhenfeizhang mentioned this pull request Aug 4, 2023

address additional comments on #712 #726

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#711 + #713 remove num chunks from public input; relax the constraints for the dummy chunk proofs to avoid dummy chunk proofgen time #712

#711 + #713 remove num chunks from public input; relax the constraints for the dummy chunk proofs to avoid dummy chunk proofgen time #712

zhenfeizhang commented Aug 2, 2023 •

edited

Loading

kunxian-xia commented Aug 3, 2023

zhenfeizhang commented Aug 3, 2023

kunxian-xia commented Aug 4, 2023

kunxian-xia left a comment

zhenfeizhang commented Aug 4, 2023

#711 + #713 remove num chunks from public input; relax the constraints for the dummy chunk proofs to avoid dummy chunk proofgen time #712

#711 + #713 remove num chunks from public input; relax the constraints for the dummy chunk proofs to avoid dummy chunk proofgen time #712

Conversation

zhenfeizhang commented Aug 2, 2023 • edited Loading

Description

Issue Link

Type of change

Contents

Rationale

How Has This Been Tested?

kunxian-xia commented Aug 3, 2023

zhenfeizhang commented Aug 3, 2023

kunxian-xia commented Aug 4, 2023

kunxian-xia left a comment

Choose a reason for hiding this comment

zhenfeizhang commented Aug 4, 2023

zhenfeizhang commented Aug 2, 2023 •

edited

Loading